Size is one consideration, but for me the biggest reason that I upgraded to the 4G iPod is the one that Apple hasn't ever mentioned: They increased the backlight on the 4G and that makes a world of difference. Keep the 2G, they make the best harddrives.
Tiger: The Good, the Bad, and the Ugly
A Fixed One or a New One? Buying Your Second iPod